<html>
<head><meta charset="utf-8"><title>Reassigning my PRs · t-libs · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/index.html">t-libs</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reassigning.20my.20PRs.html">Reassigning my PRs</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="216513365"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Reassigning%20my%20PRs/near/216513365" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Kalbertodt <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reassigning.20my.20PRs.html#216513365">(Nov 12 2020 at 19:06)</a>:</h4>
<p>Hi everyone!</p>
<p>I just went through the list of my assigned PRs. In order to not let people wait any longer than necessary, it would probably be wise to reassign them. (I can't reassign nor merge them anymore). </p>
<p>These I have not yet looked at so they should certainly be reassigned:</p>
<ul>
<li>"Take 2: Add <code>take_...</code> functions to slices" - <a href="https://github.com/rust-lang/rust/pull/77065">https://github.com/rust-lang/rust/pull/77065</a></li>
<li>"Split each iterator adapter and source into individual modules" - <a href="https://github.com/rust-lang/rust/pull/77697">https://github.com/rust-lang/rust/pull/77697</a></li>
<li>"Refactor and fix <code>parse_prefix</code> on Windows" - <a href="https://github.com/rust-lang/rust/pull/78833">https://github.com/rust-lang/rust/pull/78833</a></li>
</ul>
<p>Here, the next steps are unclear (wait for improved pattern API?): </p>
<ul>
<li>"Implement String::remove_matches" - <a href="https://github.com/rust-lang/rust/pull/71780">https://github.com/rust-lang/rust/pull/71780</a></li>
</ul>
<p>And this one needs a decision (FCP?): </p>
<ul>
<li>"Format Duration microseconds with 'us' suffix, without Unicode" - <a href="https://github.com/rust-lang/rust/pull/75065">https://github.com/rust-lang/rust/pull/75065</a></li>
</ul>
<p>Thank you all!</p>



<a name="216515599"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Reassigning%20my%20PRs/near/216515599" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Kalbertodt <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reassigning.20my.20PRs.html#216515599">(Nov 12 2020 at 19:24)</a>:</h4>
<p>I found two more:</p>
<ul>
<li>"Doc change: Remove mention of <code>fnv</code> in HashMap" - <a href="https://github.com/rust-lang/rust/pull/77996">https://github.com/rust-lang/rust/pull/77996</a> </li>
<li>"Add a way to limit inheritable handles when spawning child process on Windows" -  <a href="https://github.com/rust-lang/rust/pull/75551">https://github.com/rust-lang/rust/pull/75551</a></li>
</ul>



<a name="216517449"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Reassigning%20my%20PRs/near/216517449" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reassigning.20my.20PRs.html#216517449">(Nov 12 2020 at 19:41)</a>:</h4>
<blockquote>
<p>"Doc change: Remove mention of fnv in HashMap" - <a href="https://github.com/rust-lang/rust/pull/77996">https://github.com/rust-lang/rust/pull/77996</a> </p>
</blockquote>
<p>this one is ready to go I think</p>



<a name="216517456"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Reassigning%20my%20PRs/near/216517456" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reassigning.20my.20PRs.html#216517456">(Nov 12 2020 at 19:41)</a>:</h4>
<p>I'm not on T-libs, though</p>



<a name="216521644"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Reassigning%20my%20PRs/near/216521644" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reassigning.20my.20PRs.html#216521644">(Nov 12 2020 at 20:17)</a>:</h4>
<p>Thanks <span class="user-mention" data-user-id="118772">@Lukas Kalbertodt</span> ! I'll look at them.</p>
<blockquote>
<p>I can't reassign</p>
</blockquote>
<p>(I think <code>r? @someone</code> will still work.)</p>



<a name="216521828"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Reassigning%20my%20PRs/near/216521828" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Kalbertodt <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reassigning.20my.20PRs.html#216521828">(Nov 12 2020 at 20:18)</a>:</h4>
<p><span class="user-mention silent" data-user-id="310399">Mara</span> <a href="#narrow/stream/219381-t-libs/topic/Reassigning.20my.20PRs/near/216521644">said</a>:</p>
<blockquote>
<blockquote>
<p>I can't reassign</p>
</blockquote>
<p>(I think <code>r? @someone</code> will still work.)</p>
</blockquote>
<p>I thought so, too, but apparently it doesn't: <a href="https://github.com/rust-lang/rust/pull/78769#issuecomment-725933943">https://github.com/rust-lang/rust/pull/78769#issuecomment-725933943</a></p>



<a name="216521842"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Reassigning%20my%20PRs/near/216521842" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Kalbertodt <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reassigning.20my.20PRs.html#216521842">(Nov 12 2020 at 20:18)</a>:</h4>
<p>And thanks a lot!</p>



<a name="216524770"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Reassigning%20my%20PRs/near/216524770" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reassigning.20my.20PRs.html#216524770">(Nov 12 2020 at 20:37)</a>:</h4>
<p>Oh, that looks like a bug then. The highfive bot specifically has <a href="https://github.com/rust-lang/highfive/blob/af3efc54ed9406604f0d007478e1d8e24a6c38e0/highfive/newpr.py#L422">a check</a> to allow the current assignee to use that command. It should only check your access the the repository if you're not the author or assignee.</p>



<a name="216535855"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Reassigning%20my%20PRs/near/216535855" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Kalbertodt <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reassigning.20my.20PRs.html#216535855">(Nov 12 2020 at 22:04)</a>:</h4>
<p>Ah, interesting. I didn't know.</p>



<a name="216603486"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Reassigning%20my%20PRs/near/216603486" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reassigning.20my.20PRs.html#216603486">(Nov 13 2020 at 12:30)</a>:</h4>
<p><span class="user-mention" data-user-id="232545">@Joshua Nelson</span> thanks. that one is approved now. :)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>